Skip to content

feat(tray): sync status overlay for accounts menu#9397

Closed
Rello wants to merge 2 commits intomasterfrom
codex/add-sync-status-overlay-to-user-avatars-xonoie
Closed

feat(tray): sync status overlay for accounts menu#9397
Rello wants to merge 2 commits intomasterfrom
codex/add-sync-status-overlay-to-user-avatars-xonoie

Conversation

@Rello
Copy link
Collaborator

@Rello Rello commented Jan 30, 2026

Motivation

  • Improve the user menu for multiple accounts by surfacing per-account sync status so accounts with sync problems are easy to spot.

Description

  • Expose per-account sync status on the tray user model by adding syncStatusIcon and syncStatusOk properties on User and new roles SyncStatusIconRole/SyncStatusOkRole in UserModel.
  • Compute a per-account sync summary in C++ (determineSyncStatus / syncStatusForAccount) using folder sync results and map those to theme icons (ok, error, warning, pause, sync, offline).
  • Wire updates from FolderMan::folderSyncStateChange, FolderMan::folderListChanged and AccountState::isConnectedChanged into a new updateSyncStatus() method and emit model dataChanged when the status changes.
  • Overlay a non-OK sync status icon on top of account avatars in the user menu QML (UserLine.qml) placing the overlay in the top-left to avoid hiding the user status indicator.

Testing

  • No automated tests were executed for this change.

Codex Task

@Rello Rello marked this pull request as draft January 30, 2026 09:16
@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-9397.zip

Digest: sha256:d1924694183e3d04b8bd69e72232b5a2d854c97b411e143c6a3c177c8c0cee6d

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)
10.4% Duplication on New Code (required ≤ 3%)
33 New Code Smells (required ≤ 0)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Rello
Copy link
Collaborator Author

Rello commented Jan 30, 2026

Bildschirmfoto 2026-01-30 um 12 34 01

@Rello Rello linked an issue Jan 30, 2026 that may be closed by this pull request
@Rello Rello marked this pull request as ready for review January 30, 2026 19:39
@Rello Rello self-assigned this Jan 30, 2026
@Rello Rello added this to the 33.0.0 milestone Jan 30, 2026
@Rello Rello added feature: ☁️ GUI System tray icon and menu. design Design, UI, UX, etc. labels Jan 30, 2026
@Rello
Copy link
Collaborator Author

Rello commented Jan 31, 2026

Account offline example

Bildschirmfoto 2026-01-31 um 15 34 24

@Rello Rello changed the title fix: show sync status overlay for accounts feat(tray): sync status overlay for accounts menu Feb 5, 2026
@Rello
Copy link
Collaborator Author

Rello commented Feb 5, 2026

#9427

@Rello Rello closed this Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review codex design Design, UI, UX, etc. feature: ☁️ GUI System tray icon and menu.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync status overlay for account avatar listing

1 participant