feat(6404,gui): clarify exclusion list scopes, add link to global exl… - #10747
Open
Gromhold wants to merge 1 commit into
Open
feat(6404,gui): clarify exclusion list scopes, add link to global exl…#10747Gromhold wants to merge 1 commit into
Gromhold wants to merge 1 commit into
Conversation
Gromhold
requested review from
camilasan,
claucambra,
i2h3,
mgallien and
nilsding
as code owners
September 4, 2026 13:02
claucambra
reviewed
Sep 4, 2026
claucambra
left a comment
claucambra
left a comment
Collaborator
There was a problem hiding this comment.
Code-wise I don't see any issues
@nextcloud/designers thoughts on this?
…usion settings Clarify that the global exclusion list applies to all accounts and synchronized folders and the folder-specific list applies only to the selected folder. Label folder-specific exclusion list with the folder name and added a link to the global exclusion settings. Add tests for both descriptions and the global-editor request. Assisted-by: Codex:GPT-5 Signed-off-by: Gromhold <matthias.doenges01@gmail.com>
Gromhold
force-pushed
the
feat/6404-clarify-ignore-lists
branch
from
September 7, 2026 14:34
ed2615d to
bd25090
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #6404
Summary
Updated the exclusion-list descriptions for the global and folder-specific settings. The global dialog now clarifies that the exclusion list applies to all accounts and synced folders, while the folder-specific dialog explains that it only applies to the current folder. The folder-specific dialog also displays the current folder name and includes a link to the global exclusion-list. Added tests to verify both descriptions and the link behavior.
Successfully ran AccountSettingsTest and built the desktop client. Manually verified the global and folder-specific dialogs, including that the link opens the global exclusion settings. Formatted the modified C++ files with clang-format and ran clang-tidy-21 on the modified C++ files.
Global and specific exclusion lists (Before/After)
Checklist
AI (if applicable)