fix(activity): use window text color for scroll button - #10746
Open
Rello wants to merge 1 commit into
Open
Conversation
Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5
Rello
requested review from
camilasan,
claucambra,
i2h3,
mgallien and
nilsding
as code owners
September 4, 2026 12:46
Collaborator
Author
|
/backport to stable-34.0 |
|
claucambra
requested changes
Sep 4, 2026
| Accessible.onPressAction: scrollToTopButton.clicked() | ||
|
|
||
| icon.source: "image://svgimage-custom-color/chevron-double-up.svg/" + palette.buttonText | ||
| icon.source: "image://svgimage-custom-color/chevron-double-up.svg/" + palette.windowText |
Collaborator
There was a problem hiding this comment.
buttontext should work, if it doesn't there is a broader issue with the palette here
Rello
marked this pull request as draft
September 4, 2026 14:59
Collaborator
dark mode on windows
|
Collaborator
|
light mode |
mgallien
approved these changes
Sep 7, 2026
Rello
marked this pull request as ready for review
September 7, 2026 12:26
Collaborator
Author
|
/backport to stable-34.0 |
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10746.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the client鈥檚 dark-mode-aware foreground
fixes #10740
Assisted-by: Codex:GPT-5