fix: Account Wizard UX fixes#10114
Conversation
Rello
commented
Jun 5, 2026
Rello
commented
- V2 poll timer
- folder-already used check
- remove option to reuse or clean up (backup) existing sync folder
- dock icon when account wizard is active
- tray menu also opens when 0 accounts
- tray menu UI when 0 accounts
- macOS default sync folder
- remove unnecessary log warnings
- accessiblity labels
Rello
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d79fe36d8e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (AccountManager::instance()->accounts().isEmpty()) { | ||
| if (_tray->isOpen()) { | ||
| _tray->hideWindow(); | ||
| } else { | ||
| _tray->showWindow(); |
There was a problem hiding this comment.
When there are no accounts during first-run setup, this branch runs before the following OwncloudSetupWizard::bringWizardToFrontIfVisible() check, so clicking the tray icon toggles the empty-account tray instead of raising the already-open account wizard. If the wizard is behind other windows while adding the first account, the tray icon no longer helps recover it; keep the wizard check ahead of the empty-account branch.
Useful? React with 👍 / 👎.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| : QObject(parent) | ||
| { | ||
| } | ||
| ~ForegroundBackground() = default; |
There was a problem hiding this comment.
annotate this function with override or (rarely) final
| ~ForegroundBackground() = default; | |
| ~ForegroundBackground() override = default; |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88cbb116a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const auto localFolder = QDir(localSyncFolder); | ||
| return localFolder.exists() |
There was a problem hiding this comment.
When the chosen sync folder contains only hidden/system metadata (for example .DS_Store after browsing a folder on macOS), this helper now treats the folder as non-empty because it includes QDir::Hidden | QDir::System; validateLocalSyncFolder() then rejects the selection with “Please choose an empty local sync folder.” This blocks otherwise empty folders that the OS has touched, so the data check should exclude harmless metadata or match the previous visible-entry behavior.
Useful? React with 👍 / 👎.
|
- V2 poll timer - folder-already used check - remove option to reuse or clean up (backup) existing sync folder - dock icon when account wizard is active - tray menu also opens when 0 accounts - tray menu UI when 0 accounts - macOS default sync folder - remove unnecessary log warnings - accessiblity labels Signed-off-by: Rello <github@scherello.de>
Signed-off-by: Rello <github@scherello.de>
mgallien
force-pushed
the
bugfix/AccountWizard
branch
from
88cbb11 to
cf61ebd
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-10114.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
1 participant
