Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated macOS App Icon #10113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Updated macOS App Icon #10113
Changes from all commits
cb18b65e9ffa76File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
Check warning on line 212 in src/libsync/theme.cpp
Edit this comment to use the C++ format, i.e. "//".
Check warning on line 380 in src/libsync/theme.cpp
implicit conversion loses integer precision: 'qsizetype' (aka 'long long') to 'const int'
Check warning on line 456 in src/libsync/theme.cpp
Avoid this unnecessary copy by using a "const" reference.
Check warning on line 459 in src/libsync/theme.cpp
Replace "->" with "::" for access to "QGuiApplication::platformName".
Check warning on line 739 in src/libsync/theme.cpp
Unmodified variable "status" of type "enum OCC::SyncResult::Status" should be const-qualified.
Check warning on line 741 in src/libsync/theme.cpp
Take the required action to fix the issue indicated by this "FIXME" comment.
Check warning on line 767 in src/libsync/theme.cpp
Remove this redundant "case" clause.
Check warning on line 1041 in src/libsync/theme.cpp
Replace "->" with "::" for access to "QGuiApplication::styleHints".
Check warning on line 1047 in src/libsync/theme.cpp
Unmodified variable "systemPalette" of type "class QPalette" should be const-qualified.
Check warning on line 1085 in src/libsync/theme.cpp
Replace "->" with "::" for access to "QGuiApplication::styleHints".
Check failure on line 1085 in src/libsync/theme.cpp
Add a "default" case to this switch statement.
Check warning on line 1160 in src/libsync/theme.cpp
This function should be declared "const".
Check failure on line 8 in src/libsync/theme_mac.h
src/libsync/theme_mac.h:8:10 [clang-diagnostic-error]
Check warning on line 10 in src/libsync/theme_mac.h
src/libsync/theme_mac.h:10:11 [cppcoreguidelines-avoid-non-const-global-variables]
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.