[stable-4.0] fix(networkjobs): move processEvents after reply reads in LsColJob#10102
Draft
backportbot[bot] wants to merge 1 commit into
Draft
[stable-4.0] fix(networkjobs): move processEvents after reply reads in LsColJob#10102backportbot[bot] wants to merge 1 commit into
backportbot[bot] wants to merge 1 commit into
Conversation
fix(networkjobs): move processEvents after reply reads in LsColJob LsColJob::finished() called QCoreApplication::processEvents() before reading the reply. A pending deleteLater() processed during that call would zero the QPointer<QNetworkReply>, causing a SIGSEGV on the subsequent reply()->request().url().path() access. Fix: move processEvents to after all reply() accesses so the pointer cannot be invalidated before it is used. Signed-off-by: Camila Ayres <hello@camilasan.com> [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10093
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.