Feature/governance labels integration#10100
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| void setCustomEntityType(const QString &newCustomEntityType); | ||
|
|
||
| QString entityId() const; |
There was a problem hiding this comment.
function entityId should be marked [[nodiscard]]
| QString entityId() const; | |
| [[nodiscard]] QString entityId() const; |
will enable to share type definitions in all real jobs Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
also improve the available properties for the job parameters Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
finish implementing most of the code needed to send requests to the governance API will need further work to see how to read the replies and make something usefull Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
feature/governanceLabelsIntegration
branch
from
08ca064 to
1582c09
Compare
github-actions
Bot
dismissed
their stale review
No Clang-Tidy warnings found so I assume my comments were addressed
mgallien
force-pushed
the
feature/governanceLabelsIntegration
branch
from
1582c09 to
9af8192
Compare
|
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
feature/governanceLabelsIntegration
branch
from
9af8192 to
b830eeb
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-10100.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
1 participant
Thanks for opening a pull request on the Nextcloud desktop client.
Before sending a pull request that fixes a security issue please report it via our HackerOne page (https://hackerone.com/nextcloud) following our security policy (https://nextcloud.com/security/).
This allows us to coordinate the fix and release without potentially exposing all Nextcloud client users in the meantime.
Instead of a Contributor License Agreement (CLA) we use a Developer Certificate of Origin (DCO).
https://en.wikipedia.org/wiki/Developer_Certificate_of_Origin
-->
Resolves
#
Close https://github.com/nextcloud-gmbh/server/issues/953
Close https://github.com/nextcloud-gmbh/server/issues/957
Summary
TODO
Checklist
AI (if applicable)