feat(UI): Updated settings dialog UI

[Rello]

#9979

[Rello]

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

[github-actions]

⚠️ modernize-use-override ⚠️
annotate this function with override or (rarely) final

Suggested change

	void initStyleOption(QStyleOptionToolButton *option) const
	void initStyleOption(QStyleOptionToolButton *option) const override

[kra-mo]

From the screenshots:

• Some of the settings seem to be translated, but some not. Was this already the case or did this break it?
• Where does the style of toggle switches come from? It's inconsistent with how it looks for virtual files. If it's custom, it would be good to make them look like how our switches look on the web anyway, or if not, get it to be consistent with virtual files.
• It would be good if the alignment of classic sync could be fixed as well (and also the gap between the title and description of virtual files, and the text clipping there).

The rest looks like improvements, a good next step.

[Rello]

@kra-mo

• Some of the settings seem to be translated, but some not. Was this already the case or did this break it?

as soon as its in master, the strings will be updated via transifex. the strings itself did not change, but their location.

• Where does the style of toggle switches come from? It's inconsistent with how it looks for virtual files. If it's custom, it would be good to make them look like how our switches look on the web anyway, or if not, get it to be consistent with virtual files.

it is custom and now also virtual files is using the same switch as the others. what you mean by web? these now smaller ones?

• It would be good if the alignment of classic sync could be fixed as well (and also the gap between the title and description of virtual files, and the text clipping there).

looking at it. its a completely different sub-window. thats why its a little annoying

[github-actions]

Artifact containing the AppImage: nextcloud-appimage-pr-10031.zip

Digest: sha256:1f967c9cac41b24d3959cd4e5b19fc4abcfcc45b9ed3129fbce75193b9989959

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

[kra-mo]

these now smaller ones?

Yes

[sonarqubecloud]

Quality Gate failed

Failed conditions
1 Security Hotspot
5.9% Coverage on New Code (required ≥ 80%)
1 New Bugs (required ≤ 0)
E Reliability Rating on New Code (required ≥ A)
219 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE