Repository navigation
Conversation
…ner after occ deck:transfer-ownership (send UserShareAccessUpdatedEvent event to the source and target users) Assisted-by: ClaudeCode:Opus 5.5 Signed-off-by: Sebastien Marinier <seb@smarinier.net>
smarinier
force-pushed
the
fix/8681_card_attachments_after_transfer_ownership
branch
from
November 6, 2026 17:26
dabedef to
7b772a2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deck creates attachment shares with the target
/{DECK_PLACEHOLDER}/<filename>. For each recipient,OCA\Deck\Sharing\Listener::overwriteMountPoint()replaces the placeholder with the recipient's attachment folder when files_sharing listens toVerifyMountPointEvent.Since Nextcloud 33, files_sharing only verifies a recipient's share mount points (
ShareRecipientUpdater) when it is told that the recipient's access changed, throughOCA\Files_Sharing\Event\UserShareAccessUpdatedEvent(or a share created, moved or deleted event). Deck already dispatches this event when:AclCreatedRemovedListener),BoardService::delete()/deleteUndo()).BoardService::transferBoardOwnership()does not dispatch it:BoardMapper::transferOwnership(),AclMapper::deleteParticipantFromBoard(), which dispatches no event.As a result, the new owner gets access to the attachment shares, but their mount points are never verified. The shares are mounted under the raw
/{DECK_PLACEHOLDER}/…target, a folder that does not exist. With--remap, the previous owner also loses access to the board without the event, so their share mounts are stale as well.TODO
Checklist
🤖 AI (if applicable)