Repository navigation
Conversation
…nts via OCS API
In appinfo/routes.php, attachment_ocs#update was registered before
attachment_ocs#delete without regex restrictions on {attachmentId}.
Because {attachmentId} defaults to [^/]+, it greedily matched
{type}:{attachmentId} (such as 'file:92921') and rejected DELETE
requests with HTTP 405 Method Not Allowed before attachment_ocs#delete
could be evaluated.
This moves attachment_ocs#delete before update and adds strict regex
requirements for {type} and {attachmentId}.
Signed-off-by: aquananu <AQUANANU@GMAIL.COM>
Member
|
Possibly related to #8146? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nts via OCS API
In appinfo/routes.php, attachment_ocs#update was registered before attachment_ocs#delete without regex restrictions on {attachmentId}. Because {attachmentId} defaults to [^/]+, it greedily matched {type}:{attachmentId} (such as 'file:92921') and rejected DELETE requests with HTTP 405 Method Not Allowed before attachment_ocs#delete could be evaluated.
This moves attachment_ocs#delete before update and adds strict regex requirements for {type} and {attachmentId}.
Summary
TODO
Checklist
🤖 AI (if applicable)