Feat/floating editor - #5583
Closed
GretaD wants to merge 2 commits into
Closed
Conversation
…ditor Signed-off-by: greta <gretadoci@gmail.com>
…ating editor Signed-off-by: greta <gretadoci@gmail.com>
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
odzhychko
requested changes
Aug 11, 2026
odzhychko
left a comment
odzhychko
left a comment
There was a problem hiding this comment.
Text properties are now in a more muted color. (I guess this is the goal of this PR?)
But the Name seems missaligned.
| @@ -306,8 +306,13 @@ export default { | |||
| } | |||
|
|
|||
| .contact-title { | |||
There was a problem hiding this comment.
Name is weirdly aligned.
I tested it together with current main (1968041ebcbd120bfce97be65d40fe636428252b) of Mail.
Will check later with how it looks with nextcloud/mail#13282
Before
After
Contributor
There was a problem hiding this comment.
(Name in the top right corner)
There was a problem hiding this comment.
Contributor
Author
|
this not relevant anymore, it was fixed on mail side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)