Skip to content

ci: Add terser-webpack-plugin to the dev dependency definition#928

Merged
AndyScherzinger merged 1 commit into
mainfrom
ci/noid/terser-definition
Jul 10, 2026
Merged

ci: Add terser-webpack-plugin to the dev dependency definition#928
AndyScherzinger merged 1 commit into
mainfrom
ci/noid/terser-definition

Conversation

@AndyScherzinger

Copy link
Copy Markdown
Member

, given it is used there.

Needed to make npm audit work

Assisted-by: ClaudeCode:claude-sonnet-5

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

… it is used there

Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger added bug Something isn't working dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Jul 10, 2026
@AndyScherzinger AndyScherzinger added this to the Nextcloud 35 milestone Jul 10, 2026
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 70acc619-6f75-4256-9934-b16ae4eb5531

📥 Commits

Reviewing files that changed from the base of the PR and between c2a5bf8 and adae402.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • build-js/WebpackSPDXPlugin.js
  • package.json

📝 Walkthrough

Walkthrough

The Webpack SPDX plugin now terminates package-directory recursion when path.dirname(dir) equals dir. The project also adds terser-webpack-plugin version ^5.3.11 to devDependencies.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the dependency addition, which is a main change in the pull request.
Description check ✅ Passed The description is related to the dependency update and the npm audit motivation, so it matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AndyScherzinger AndyScherzinger merged commit 1e27912 into main Jul 10, 2026
53 of 54 checks passed
@AndyScherzinger AndyScherzinger deleted the ci/noid/terser-definition branch July 10, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant