-
Notifications
You must be signed in to change notification settings - Fork 26
feat: add release relay and npm audit fix workflows #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kyteinsky
merged 2 commits into
main
from
feat/add-release-relay-and-npm-audit-fix-workflows
Jul 9, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| # This workflow is provided via the organization template repository | ||
| # | ||
| # https://github.com/nextcloud/.github | ||
| # https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization | ||
| # | ||
| # SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors | ||
| # SPDX-License-Identifier: MIT | ||
|
|
||
| name: Npm audit fix and compile | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| # At 2:30 on Sundays | ||
| - cron: '30 2 * * 0' | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| branches: | ||
| - ${{ github.event.repository.default_branch }} | ||
| - 'stable34' | ||
| - 'stable33' | ||
| - 'stable32' | ||
|
|
||
| name: npm-audit-fix-${{ matrix.branches }} | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| id: checkout | ||
| uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||
| with: | ||
| persist-credentials: false | ||
| ref: ${{ matrix.branches }} | ||
| continue-on-error: true | ||
|
|
||
| - name: Read package.json node and npm engines version | ||
| uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3 | ||
| id: versions | ||
| with: | ||
| fallbackNode: '^24' | ||
| fallbackNpm: '^11.3' | ||
|
|
||
| - name: Set up node ${{ steps.versions.outputs.nodeVersion }} | ||
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| with: | ||
| node-version: ${{ steps.versions.outputs.nodeVersion }} | ||
|
|
||
| - name: Set up npm ${{ steps.versions.outputs.npmVersion }} | ||
| run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}' | ||
|
|
||
| - name: Fix npm audit | ||
| id: npm-audit | ||
| uses: nextcloud-libraries/npm-audit-action@1b1728b2b4a7a78d69de65608efcf4db0e3e42d0 # v0.2.0 | ||
|
|
||
| - name: Run npm ci and npm run build | ||
| if: steps.checkout.outcome == 'success' | ||
| env: | ||
| CYPRESS_INSTALL_BINARY: 0 | ||
| run: | | ||
| npm ci | ||
| npm run build --if-present | ||
|
|
||
| - name: Create Pull Request | ||
| if: steps.checkout.outcome == 'success' | ||
| uses: peter-evans/create-pull-request@5f6978faf089d4d20b00c7766989d076bb2fc7f1 # v8.1.1 | ||
| with: | ||
| token: ${{ secrets.COMMAND_BOT_PAT }} | ||
| commit-message: 'fix(deps): Fix npm audit' | ||
| committer: GitHub <noreply@github.com> | ||
| author: nextcloud-command <nextcloud-command@users.noreply.github.com> | ||
| signoff: true | ||
| branch: automated/noid/${{ matrix.branches }}-fix-npm-audit | ||
| title: '[${{ matrix.branches }}] Fix npm audit' | ||
| body: ${{ steps.npm-audit.outputs.markdown }} | ||
| labels: | | ||
| dependencies | ||
| 3. to review | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # This workflow is provided via the organization template repository | ||
| # | ||
| # https://github.com/nextcloud/.github | ||
| # https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization | ||
| # | ||
| # SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| # SPDX-License-Identifier: MIT | ||
|
|
||
| name: Notify release-relay on release | ||
|
|
||
| on: | ||
| release: | ||
| types: [published] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| notify: | ||
| name: Dispatch release to release-relay | ||
| runs-on: ubuntu-latest | ||
|
|
||
| # Only allowed to run on nextcloud-releases repositories | ||
| if: ${{ github.repository_owner == 'nextcloud-releases' }} | ||
|
|
||
| steps: | ||
| - name: Check actor permission | ||
| uses: skjnldsv/check-actor-permission@69e92a3c4711150929bca9fcf34448c5bf5526e7 # v3.0 | ||
| with: | ||
| require: write | ||
|
|
||
| - name: Dispatch to release-relay | ||
| uses: peter-evans/repository-dispatch@28959ce8df70de7be546dd1250a005dd32156697 # v4.0.1 | ||
| with: | ||
| token: ${{ secrets.DISPATCH_PAT }} | ||
| repository: nextcloud-gmbh/release-relay | ||
| event-type: app-tagged | ||
| client-payload: '{"app": "${{ github.repository }}", "tag": "${{ github.event.release.tag_name }}"}' |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Intermediate steps lack checkout outcome guard, causing job failures for missing branches.
Checkout uses
continue-on-error: true(line 42) to gracefully handle branches that don't exist, and the build/PR steps (lines 64, 72) correctly guard withif: steps.checkout.outcome == 'success'. However, the steps in between — read package versions (44-49), setup node (51-54), setup npm (56-57), and npm audit fix (59-61) — have no such guard. When a branch doesn't exist, these steps will run against an empty workspace and fail (nopackage.json), stopping the job and defeating the purpose ofcontinue-on-erroron checkout.🛡️ Proposed fix: add checkout outcome guard to intermediate steps
📝 Committable suggestion