Repository navigation
feat(login): add per-account custom request headers - #17926
Open
laugmanuel wants to merge 1 commit into
Open
laugmanuel wants to merge 1 commit into
laugmanuel wants to merge 1 commit into
Conversation
Allow additional request headers per account, for example the credentials of a pre-authentication proxy - Login: collapsible "Advanced options" below the QR button with a "Name: value" field. Headers are captured only for server checks the user started, registered provisionally for the typed origin and stored in the account only if the account ends up on that origin. - Accounts: headers are kept as account user data, registered at app start, reconciled after an account was removed and editable later via "Custom headers" in the account menu. - Web views: GET requests to a registered origin go through the library client, which follows redirects only within that origin and syncs cookies on every hop; main frame redirects navigate to their target. Other requests of the page's fetch and XMLHttpRequest calls get the headers from a per-origin page script; fetch rejects redirects for them. - Glide: images of registered origins are loaded through the library client. - The transport for web views and Glide verifies host names like the web view does, accepting a mismatch only for certificates the user accepted. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Manuel Laug <laugmanuel@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow additional request headers per account, for example the credentials of a pre-authentication proxy
This fixes #5821
This PR requires nextcloud/android-library#2192 and a library bump.
🖼️ Screenshots
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)