Skip to content

refactor(get-public-key): rename to get certificate - #17860

Open
alperozturk96 wants to merge 2 commits into
masterfrom
remove-confusion-for-e2ee-operations
Open

refactor(get-public-key): rename to get certificate#17860
alperozturk96 wants to merge 2 commits into
masterfrom
remove-confusion-for-e2ee-operations

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 added the ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) label Oct 21, 2026
@alperozturk96 alperozturk96 mentioned this pull request Oct 21, 2026
Open
@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../java/com/nextcloud/utils/e2ee/E2EEKeyInspector.kt 0.00% 1 Missing ⚠️
...oid/operations/CreateShareWithShareeOperation.java 0.00% 1 Missing ⚠️
...g/setupEncryption/SetupEncryptionDialogFragment.kt 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit fcd9146
Version 17860
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

daniele-verducci
daniele-verducci previously requested changes Oct 22, 2026
View reviewed changes

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Alper,
I noticed a strange thing: I cannot open an encrypted foder whose key was generated from another client (web in this case). Example: (left is QA build from this PR, right is 35.0.1 (prod) ):

Screencast_20261022_154202.webm

Logs:

logs.txt

@alperozturk96
refactor(get-public-key): rename to get certificate
fcec99f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	gradle/libs.versions.toml
@alperozturk96
alperozturk96 force-pushed the remove-confusion-for-e2ee-operations branch from 8286059 to fcec99f Compare October 27, 2026 15:25
@alperozturk96
wip
fcd9146 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96

alperozturk96 commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator Author

Hey Alper, I noticed a strange thing: I cannot open an encrypted foder whose key was generated from another client (web in this case). Example: (left is QA build from this PR, right is 35.0.1 (prod) ):

Screencast_20261022_154202.webm
Logs:

logs.txt

I can't able to reproduce this. Could you please test via fresh account and fresh keys?

@alperozturk96
alperozturk96 dismissed daniele-verducci’s stale review October 27, 2026 15:29

i thinks its related to the server 429 errors. local instance can have this.

@github-actions

github-actions Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness5151
Dodgy code148148
Experimental11
Malicious code vulnerability11
Multithreaded correctness2020
Performance2828
Security1515
Total288288

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky
@daniele-verducci daniele-verducci Awaiting requested review from daniele-verducci

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @daniele-verducci