Repository navigation
Conversation
bd45049 to
5bbf83a
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Visit cached descendants even when their parent ETag is unchanged and persist newly discovered folders before visiting their children. Process missing files sequentially within the foreground two-way sync worker. Keep manual service dispatch, propagate transfer errors to the root, check ongoing constraints between files, and save completion status using fresh folder metadata. Cover traversal, cancellation, error handling, operation reuse, and worker completion with unit tests. Assisted-by: Codex:gpt-6.1-sol Signed-off-by: Oskars Pucka <89988568+oskarsss@users.noreply.github.com>
5bbf83a to
ad3ef31
Compare
Problem
Enabling sync on a folder could leave deeply nested files undownloaded. An unchanged parent folder ETag could prevent traversal into its descendants.
Changes
Testing
An earlier test.2 device run downloaded 1,213 additional files totaling 6.50 GB in approximately 44 minutes. All newly downloaded file sizes matched the server, and three sampled deep files also matched server SHA-256 hashes.
These measurements demonstrate recursive download completion; they are not a controlled speed comparison with the original app.
Test APK
https://github.com/oskarsss/android/releases/tag/stable-35.0.1-recursive-sync-test.3
Known limitations
Manual Sync and Sync all transfers, encrypted folders, and upload/conflict behavior have not been verified in the latest device run.
Stable QA lint reports an existing ObsoleteSdkInt error in unchanged QA icon resources.
AI assistance
Implementation, cleanup, and automated testing were assisted by Codex (GPT-6.1-Sol).