Fix conflicts for offline uploads when uploading same file again - #17590
Open
daniele-verducci wants to merge 12 commits into
Open
Fix conflicts for offline uploads when uploading same file again#17590daniele-verducci wants to merge 12 commits into
daniele-verducci wants to merge 12 commits into
Conversation
Contributor
Author
|
@tobiasKaminsky should this be in milestone 35 or 36? |
|
APK file: https://github.com/nextcloud/android/actions/runs/34251212640/artifacts/10066358893 |
alperozturk96
requested changes
Sep 9, 2026
daniele-verducci
force-pushed
the
fix/internal-104835
branch
from
September 9, 2026 10:12
7ae46de to
aea7023
Compare
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
… already uploaded file Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
…g etagOnServer field properly in UploadFileOperation Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
alperozturk96
force-pushed
the
fix/internal-104835
branch
from
September 9, 2026 12:18
cbe3c19 to
ea79580
Compare
alperozturk96
approved these changes
Sep 9, 2026
… edge cases Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
…d new name to the one used for online Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Contributor
Author
|
Hey @alperozturk96 , as anticipated I fixed also the missing case, so I re-requested your review. You can check just the last 4 (new) commits.
So, the last commits fixes the dialog content and the overwrite. If approved, will close #17589 . Thank you! |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the conflict message being shown for offline uploads when the offline-uploaded file is the same as the remote. This makes the behavior aligned with what happens online.
How to repro:
Now execute the same actions in a new folder without going offline:
This is because the offline upload erases the etag_on_server field for the already existing db entry.
This PR fixes this issue.
This PR does NOT fix #17589
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)