fix(auto-upload): edge cases - #17578
Conversation
|
APK file: https://github.com/nextcloud/android/actions/runs/34127431437/artifacts/10020989893 |
|
APK file: https://github.com/nextcloud/android/actions/runs/34135054346/artifacts/10024072271 |
988f670 to
e761346
Compare
|
APK file: https://github.com/nextcloud/android/actions/runs/34193719975/artifacts/10043268405 |
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
…r active operation for file upload helper, introduce isResolvedByCurrentCollisionPolicy Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
7c38315 to
0e85a81
Compare
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://github.com/nextcloud/android/actions/runs/34196516625/artifacts/10044444900 |
|
/backport to stable-35.0.x |
daniele-verducci
left a comment
There was a problem hiding this comment.
Hey Alper, I found a couple of issues:
- in battery saving mode, the battery saving banner in Uploads or Auto upload is now shown
- in battery saving mode, the files added to the auto upload folders are uploaded anyway
- if I block the uploads via the button in Uploads, the autouploads are correctly blocked as well. On a side note, adding a new file shows an "Uploading" notification anyway, but the file is not uploaded, so it's ok.
I tested on the Android 17 emulator, on the Android 10 old phone and on my Fairphone with a 5k files folder. It scanned it and started uploading in a couple of minutes, so it seems fast.
Changes
blocksAutoUploadfor power management and uses new mock factory to prevent duplicationAutoUploadRescanWorkerMAX_UPLOADS_PER_QUERYto get uploads