Skip to content

fix(auto-upload): edge cases - #17578

Open
alperozturk96 wants to merge 11 commits into
masterfrom
fix/auto-upload-edge-cases
Open

fix(auto-upload): edge cases#17578
alperozturk96 wants to merge 11 commits into
masterfrom
fix/auto-upload-edge-cases

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Changes

  • Adds indexes for faster database scans
  • Introduces new field blocksAutoUpload for power management and uses new mock factory to prevent duplication
  • Introduces a new periodic worker for auto upload instead of relying on uri detection. AutoUploadRescanWorker
  • Uses MAX_UPLOADS_PER_QUERY to get uploads
  • Uses global pause button for auto upload
  • Handles other edge cases

@alperozturk96 alperozturk96 added 2. developing performance 🚀 Performance improvement opportunities (non-crash related) feature: auto upload labels Sep 7, 2026
@alperozturk96 alperozturk96 added this to the Nextcloud App 35.0.0 milestone Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/34127431437/artifacts/10020989893
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/34135054346/artifacts/10024072271
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
alperozturk96 force-pushed the fix/auto-upload-edge-cases branch from 988f670 to e761346 Compare September 8, 2026 06:12
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/34193719975/artifacts/10043268405
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
…r active operation for file upload helper, introduce isResolvedByCurrentCollisionPolicy

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the fix/auto-upload-edge-cases branch from 7c38315 to 0e85a81 Compare September 8, 2026 06:51
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness5858
Dodgy code195195
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3737
Security1919
Total373373

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/34196516625/artifacts/10044444900
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96

Copy link
Copy Markdown
Collaborator Author

/backport to stable-35.0.x

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Alper, I found a couple of issues:

  • in battery saving mode, the battery saving banner in Uploads or Auto upload is now shown
image
  • in battery saving mode, the files added to the auto upload folders are uploaded anyway
  • if I block the uploads via the button in Uploads, the autouploads are correctly blocked as well. On a side note, adding a new file shows an "Uploading" notification anyway, but the file is not uploaded, so it's ok.

I tested on the Android 17 emulator, on the Android 10 old phone and on my Fairphone with a 5k files folder. It scanned it and started uploading in a couple of minutes, so it seems fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review backport-request feature: auto upload performance 🚀 Performance improvement opportunities (non-crash related)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants