improve: fetch-template - #17569
Open
alperozturk96 wants to merge 5 commits into
Open
Conversation
The redundant elvis on fileNames belongs to neither the crash fix nor the Kotlin conversion, so it goes back to its previous form to keep this branch scoped to one concern. Assisted-by: ClaudeCode:claude-opus-5
When the template list comes back empty the dialog had no selected template, so the extension check compared the typed name against null and reported "Extension cannot be changed" for every name while Create stayed disabled. Resolve the filename into a single state, treat "no template selected" as its own state, hold the error back until the user has typed, and close the dialog when no template could be loaded. Assisted-by: ClaudeCode:claude-opus-5
Fail-fast control flow, JSON node names as constants, and URL building and response parsing split into separate functions. Behaviour is unchanged. Assisted-by: ClaudeCode:claude-opus-5
alperozturk96
force-pushed
the
refactor/fetch-template
branch
from
September 7, 2026 09:58
04a5377 to
b3c6bf8
Compare
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
TemplateFilenameStateinstead of booleanshasUserInteractedguard helps to prevent error shown before the user typesFetchTemplateOperationto Kotlin