perf(file-list): db pagination - #17505
Conversation
|
APK file: https://github.com/nextcloud/android/actions/runs/32258040777/artifacts/9367607142 |
c82fa9c to
9fff08d
Compare
|
APK file: https://github.com/nextcloud/android/actions/runs/33735450064/artifacts/9887294178 |
Signed-off-by: alperozturk96 <alper_ozturk@proton.me> # Conflicts: # app/src/main/java/com/nextcloud/utils/extensions/FileDataStorageManagerExtensions.kt
9fff08d to
ef1a647
Compare
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
| suspend fun FileDataStorageManager.getSharedFileEntities(accountName: String): List<FileEntity> = | ||
| fileDao.getSharedFileIds(accountName).toEntitiesInOrderSuspended(this) | ||
|
|
||
| suspend fun FileDataStorageManager.getFavoriteFileEntities(accountName: String): List<FileEntity> = |
There was a problem hiding this comment.
On master we only show 100 at root level. Is this expected @tobiasKaminsky ?
Shared tab needs to be checked as well.
There was a problem hiding this comment.
Also, this bug is happening both on master and of course here:
- Log in
- Let it load the root folder: you have x files
- Add from another source 10k files (e.g. create them from terminal and then
occ files:scan ...) - Pull to refresh: the same files as before are shown
- Uninstall and reinstall the app, log in
- All the files, including the new ones, are shown
Issue
When user have a lot of files and/or folder in directory app crashes. Due to fetching all files at once from DB.
{ "header": { "logLevel": "ERROR", "pid": 7829, "tid": 7849, "applicationId": "com.nextcloud.client", "processName": "com.nextcloud.client", "tag": "CursorWindow", "timestamp": { "seconds": 1787142876, "nanos": 504903577 } }, "message": "Failed to read row 615, column 5 from a window with 615 rows, 52 columns" },Changes
FileEntity.How to reproduce crash?