performance: move local file

[alperozturk96]

Issue

Renaming folder too slow

Changes

• Improves performance
• Adds target and source check before move operation
• Adds tests

How to test?

• Rename folder or move files

Demo

Screen.Recording.2026-05-22.at.12.11.42.mp4

[Copilot]

Pull request overview

Refactors FileDataStorageManager.moveLocalFile(...) to a Kotlin extension-based implementation intended to improve performance/clarity, and adds unit tests around DB updates, filesystem moves, and media scan behavior when moving files/folders.

Changes:

• Replaced the inlined Java moveLocalFile implementation with a delegation to FileDataStorageManagerExtensions.moveFiles.
• Added a Room DAO bulk update method (FileDao.updateAll) and moved descendant path/storagePath update logic into DAO-backed Kotlin code.
• Added a new unit test suite covering guard conditions, entity updates, hierarchy updates, filesystem rename behavior, and media scan triggering.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
app/src/main/java/com/owncloud/android/datamodel/FileDataStorageManager.java	Delegates moveLocalFile to the Kotlin extension and exposes TAG for shared logging.
app/src/main/java/com/nextcloud/utils/extensions/FileDataStorageManagerExtensions.kt	Introduces moveFiles, filesystem move helper, and DB update logic for moved descendants + media scan handling.
app/src/main/java/com/nextcloud/client/database/dao/FileDao.kt	Adds updateAll(List<FileEntity>) for bulk updates used by the move logic.
app/src/test/java/com/owncloud/android/datamodel/MoveFilesTestBase.kt	Shared mocking/setup utilities for the new move-local-file test suite.
app/src/test/java/com/owncloud/android/datamodel/MoveFilesGuardTest.kt	Tests early-return guard behavior (null/nonexistent/root/invalid parent, etc.).
app/src/test/java/com/owncloud/android/datamodel/MoveFileEntitiesUpdateTest.kt	Tests DB entity field updates (path/pathDecrypted/storagePath/parent) for moves.
app/src/test/java/com/owncloud/android/datamodel/MoveFilesFilesystemAndMediaTest.kt	Tests filesystem rename and media scan behavior for moved media vs non-media files.
app/src/test/java/com/owncloud/android/datamodel/MoveFilesHierarchyTest.kt	Tests descendant updates (paths/parents/storagePath) when moving folders with hierarchies.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/26279321751/artifacts/7157181307
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/26497289452/artifacts/7234556505
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/26498177220/artifacts/7234919846
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	67	67
Dodgy code	216	216
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	34	34
Performance	42	42
Security	16	16
Total	420	420

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[github-actions]

test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17082-Unit-test-07-54

[alperozturk96]