Open
Conversation
Collaborator
Author
|
/backport to stable-3.36 |
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
fix/unified-search-thumbnail-icon
branch
from
a45728c to
20bb494
Compare
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16546.apk |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
AndyScherzinger
approved these changes
Feb 19, 2026
Member
AndyScherzinger
left a comment
AndyScherzinger
left a comment
There was a problem hiding this comment.
Looks better 👍
@alperozturk96 @tobiasKaminsky One thing that should get fixed though is what gets tinted and that should only be folder-icons and the archive mimetype icon. Everything else shall keep their original icon's color (!)
Member
|
PDF should not be tinted, but remain red |
Member
|
Add screenshot tests like AvatarIT for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes thumnail generation for files
Adds overlays for folders
Fixes title alignment for folders
Fixes late async adapter initialization
De-duplicate folder thumbnail generation logic introduces re-usable
OverlayManagerclass - for now it's only for folderRemoves dead-codes in
DisplayUtils