Conversation
Leo-Berman
force-pushed
the
master
branch
3 times, most recently
from
b781830 to
66753a0
Compare
|
maybe this can't be done in the frontend because if we load by timestamp in the database part then the sections will be loaded weirdly anyways? |
|
I made a change so it loads everything all at once which saves the categories but I don't really understand exactly the load it places |
|
Cross-linking discussion from forum here: https://help.nextcloud.com/t/first-pull-request-help-regarding-testing/239607 @tobiasKaminsky, maybe you can have a quick look at this if something like it would be a good idea to implement. Then, maybe you could either give some good advice on what is needed to get this merged or what would be needed to have good chances? Thanks a lot! |
Leo-Berman
force-pushed
the
master
branch
4 times, most recently
from
fe232eb to
e54d87d
Compare
|
Hi @alperozturk96 or @tobiasKaminsky I did some more work to make sure the code analysis was passing if that was a blocker. Let me know if there is anything else you'd like for me to do? Would this being a setting make it more likely to make it into master? I'm not super pressed about it, but it's more convenient for me so I don't have to keep building myself an SDK, so if there is a relatively easy way for this to happen that'd be great, and I'm willing to do a bit more work for it! |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
- Add extractFolderDate to parse YYYY/MM or YYYY/MM/DD from file paths - Sort gallery items by folder date first, then modification timestamp - Group gallery sections by month using folder date when available - Add unit tests for folder date extraction Signed-off-by: Leo Berman <leograntberman@gmail.com>
Signed-off-by: Leo Berman <leograntberman@gmail.com>
Signed-off-by: Leo Berman <leograntberman@gmail.com>
Signed-off-by: Leo Berman <leograntberman@gmail.com>
Signed-off-by: Leo Berman <leograntberman@gmail.com>
Signed-off-by: Leo Berman <leograntberman@gmail.com>
Signed-off-by: Leo Berman <leograntberman@gmail.com>
alperozturk96
force-pushed
the
master
branch
from
572705a to
3c4861f
Compare
alperozturk96
left a comment
alperozturk96
left a comment
There was a problem hiding this comment.
Hello
Thank you for the PR.
| private long endDate; | ||
| private int limit = 150; | ||
| // Use 0 for unlimited - fetch all metadata at once; thumbnails load lazily | ||
| private int limit = 0; |
There was a problem hiding this comment.
This may introduce unforeseen side effects on slow and very large instances, as forcing SearchRemoteOperation to fetch everything could cause performance issues.
@tobiasKaminsky Please share your thoughts as well.
There was a problem hiding this comment.
I have tried with my local bench, but I think it would have to be so many images before this meta data loading actually started to be a bottleneck. Of course it's just a hunch, I'm not sure what metrics to look at
app/src/main/java/com/owncloud/android/ui/adapter/GalleryAdapter.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Leo Berman <leograntberman@gmail.com>
3 participants
Uh oh!
There was an error while loading. Please reload this page.