Address recurring AI review findings in policy and agent snippets - #774
Merged
Merged
Conversation
Incorporate the code comment conventions from nextcloud/notes#1982 and generalize recurring review feedback on AI-assisted PRs: - Code comments must document the code, never the process that produced it; keep them brief and matching surrounding density - Reuse existing helpers instead of duplicating logic, and fix every occurrence of a flawed pattern - Run permission/access-control checks before the guarded operation - Wire up and test features in every reachable context (public shares, Smart Picker/reference widgets), not only the default authenticated view - Remove malformed/garbled characters from generated output Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
added
3. to review
susnux
approved these changes
Aug 10, 2026
enjeck
approved these changes
Aug 10, 2026
AndyScherzinger
added a commit
to nextcloud/files_mindmap
that referenced
this pull request
Aug 10, 2026
…ity-refinement docs(agents): sync agent rules with nextcloud/.github#774
6 tasks
AsherBond
pushed a commit
to AsherBond/talk-android
that referenced
this pull request
Aug 14, 2026
…#774 Incorporate the updated agent policy snippet: code comments must document the code rather than the process that produced it, existing helpers must be reused and flawed patterns fixed everywhere, permission checks must run before the guarded operation, user-facing changes must be wired up in every reachable context, and garbled characters must be cleaned up before submission. Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporate the code comment conventions from nextcloud/notes#1982 and generalize recurring review feedback on AI-assisted PRs:
Assisted-by: Claude Code:claude-fable-5
🤖 AI (if applicable)