fix(api): stop exporting registerImplementation - #35
Merged
Merged
Conversation
It is what the entry calls on itself to offer this copy as the page's viewer. Nothing outside the package has a reason to call it, the README said as much, and exporting it put it in the generated API docs next to registerHandler as if apps should. The ViewerCandidate type goes with it. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
added
status: review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
- Coverage 87.84% 87.84% -0.01%
==========================================
Files 36 36
Lines 2477 2476 -1
Branches 519 519
==========================================
- Hits 2176 2175 -1
Misses 297 297
Partials 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registerImplementationshowed up in the generated API docs at https://nextcloud-libraries.github.io/nextcloud-viewer/ next toregisterHandler, as if an app should call it. It is whatlib/index.tscalls on itself to offer this copy as the page's viewer; nothing outside the package has a reason to. The export goes, theViewerCandidatetype with it, and the README bullet that told people not to call it.No behaviour change, the entry still calls it at import. Covered by the public API test in
__tests__/entry.spec.ts.👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.