chore: one declaration per module, one source of defaults - #34
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
+ Coverage 83.34% 84.65% +1.31%
==========================================
Files 36 36
Lines 2420 2425 +5
Branches 476 491 +15
==========================================
+ Hits 2017 2053 +36
+ Misses 399 369 -30
+ Partials 4 3 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
`custom.d.ts` declared a module for every `.vue` file, which answers for this library's own components as well: a component whose real types stop resolving becomes `any` rather than a failed type check. It also declared `*.svg?raw` a second time, beside the one in `shims.d.ts`. What it was actually holding up is the icon package, whose types sit at a path its `exports` map does not offer, so that is what is declared now, in the one shims file. Two tests keep it that way. The viewer kept a second set of option defaults, which `open()` then replaced with whatever the caller passed anyway; the reads already fall back per option, and the service fills in the rest. Both media components reloaded on the file's display name. Two files can carry one name (a version reads as a date, a rename keeps the node) and the source is what says which bytes to fetch. The empty jsdoc blocks that were there to satisfy the linter say something now, and the duplicated comment above `modalElement()` is gone. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
chore/dead-code
branch
from
September 10, 2026 16:21
0c07a88 to
e1bdc29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/custom.d.tsdeclared a module for every.vuefile, which answers for this library's own components too: a component whose real types stop resolving quietly becomesanyinstead of failing the type check. It also declared*.svg?rawa second time, beside the one inshims.d.ts.Deleting it outright does not work, and that is the interesting part: what it was actually holding up is
vue-material-design-icons, whose types sit beside each component at a path itsexportsmap does not offer, so nothing resolves them under bundler resolution.So that package is what is declared now, in the one shims file. Two tests keep it that way: no blanket
*.vue, and no module declared in two places.The rest is smaller. The viewer kept a second set of option defaults that
open()replaced with the caller's options anyway, while every read already falls back per option. Both media components reloaded on the file's display name, where two files can carry one name (a version of a file reads as a date, a rename keeps the same node) and the source is what says which bytes to fetch. The empty jsdoc blocks that existed to satisfyjsdoc/require-jsdocsay something now, and the duplicated comment abovemodalElement()is gone.Four tests fail without the changes: the two declaration guards and one per media component for the same-name reload. The defaults collapse and the comments are covered by the suite staying green.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.