Raise error when seeking, rather than when starting box#1
Merged
nevercodecorrect merged 1 commit intoJul 23, 2026
Conversation
radarhere
force-pushed
the
jp2-oversized-box-length
branch
from
July 23, 2026 08:49
0bab2d2 to
0dbd3c6
Compare
radarhere
force-pushed
the
jp2-oversized-box-length
branch
from
July 23, 2026 12:59
0dbd3c6 to
884460a
Compare
nevercodecorrect
merged commit Jul 23, 2026
92506df
into
nevercodecorrect:jp2-oversized-box-length
40 of 41 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion for python-pillow#9818
It's hard to say about how helpful this is without a real file to use as an example, but it seems to me that it would be better to read what data we can from the image - if we move the error, we can still read the start of the box, and
next_box_type()can still return a validtbox, which could theoretically be useful.