Repository navigation
fix(types): disambiguate array return types in form containers - #358
Open
ondraondra81 wants to merge 1 commit into
Open
ondraondra81 wants to merge 1 commit into
ondraondra81 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Nette Forms 3.3.0, PHPStan 2.3.5 and phpstan-nette 2.0.15, calling
getValues('array')orgetUntrustedValues('array')inferredarray|array<mixed>. Checking the explicit 'array' argument before the generic class-string/object branch producesarray<mixed>while retaining the existing DTO and default ArrayHash clauses.This changes only the two conditional PHPDoc return declarations. The runtime implementation, parameters and template declarations are unchanged.
Differential verification on PHP 8.5.12:
setMappedTypedefaults also remains unchanged.The verification used the 3.3.0 source and is not a claim that the entire upstream suite or all PHPStan versions were tested. Please let me know if another canonical declaration is preferred.