Repository navigation
Conversation
The 'array' branch is checked first in the conditional return type, so PHPStan no longer reports array|array<mixed> and verifies the return statement of getValues(), which makes its ignoreErrors entry obsolete. Co-Authored-By: Claude Code
getControls() yields control names, which are always strings; a generator keeps them as is, so numeric names are not turned into integers. Co-Authored-By: Claude Code
The $errors and $ownErrors properties match getErrors() and getOwnErrors(), including Stringable messages. A multiple UploadControl returns a list, as its value is read with Form::DataList. Co-Authored-By: Claude Code
Co-Authored-By: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static analysis should get precise types from Nette itself, without stubs or extensions. In a few places the native phpdoc was less precise than what the code actually returns, and in one place it was wrong (
$errorsleft outStringablemessages). All changes are phpdoc-only and covered by type tests.