chore: move angular-runtime repo with git history#19
Merged
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 448 files, which is 148 over the limit of 300. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (34)
📒 Files selected for processing (448)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
serhalp
changed the title
serhalp
reviewed
Jul 2, 2026
serhalp
left a comment
serhalp
left a comment
Member
There was a problem hiding this comment.
LGTM, just a few files we should scrap
Member
There was a problem hiding this comment.
there's no such thing as a nested .github like this, we should delete this file!
Contributor
Author
There was a problem hiding this comment.
I'm aware of these pending changes. I'm trying to keep my changes to a minimum, but seems like I should just do the entire set of changes in this PR? The last comment says next PR is fine, so maybe I can leave it all for the follow-up?
Any further changes than this would simply make it difficult to review accurately, in my opinion, but I could be wrong 😅
| @@ -38,6 +38,7 @@ | |||
| } | |||
| }, | |||
| "scripts": { | |||
Member
There was a problem hiding this comment.
btw let's make sure to add publint to this package! (in the next PR or this one, either way)
serhalp
approved these changes
Jul 3, 2026
…ar-runtime#152) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…r-runtime#154) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ar-runtime#155) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ular-runtime#138) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…r-runtime#141) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…me#147) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ular-runtime#157) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…runtime#160) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lar-runtime#158) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ular-runtime#162) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ntime#164) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ar-runtime#166) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…runtime#163) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lar-runtime#167) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ar-runtime#169) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ar-runtime#170) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ular-runtime#171) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lar-runtime#172) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…runtime#173) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ar-runtime#174) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…me#168) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ar-runtime#176) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ular-runtime#177) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lar-runtime#178) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ar-runtime#179) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ular-runtime#432) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lar-runtime#433) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lify/angular-runtime#435) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…y/angular-runtime#427) * update deps, apply prettier, change to ESM, update tests * update ci tests to use Node 22 * coderabbit 1 * remove exclude * update lockfiles * lint fixes * fix prettier config * fix npm ci * coderabbit 2 * downgrade and pin angular * update engine version range to match Angular * fix version and readme * update readme to suggest latest CLI * add allowedHosts and trustedProxyHeaders * regenrate lockfiles * fix type for getContext * update readme for deploy instructions * prevent missing env vars from failing build * fix for loop bug * update swapped file templates * fix context potentially being undefined * consolidate app-engine exports in a single file * conditionally update Angular config * revert pathname to request * fix typo * fix merge conflicts * match version of angular/ssr instead of core * Update README.md Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com> * seperate version detection for angular/core and ssr * update tests * update failBuild message and remove dead code * update readme --------- Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
…etlify/angular-runtime#437) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ime#438) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…gular-runtime#439) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…gular-runtime#440) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…f skipping all due to a single missing one (netlify/angular-runtime#441) * update deps, apply prettier, change to ESM, update tests * update ci tests to use Node 22 * coderabbit 1 * remove exclude * update lockfiles * lint fixes * fix prettier config * fix npm ci * coderabbit 2 * downgrade and pin angular * update engine version range to match Angular * fix version and readme * update readme to suggest latest CLI * add allowedHosts and trustedProxyHeaders * regenrate lockfiles * fix type for getContext * update readme for deploy instructions * prevent missing env vars from failing build * fix for loop bug * update swapped file templates * fix context potentially being undefined * consolidate app-engine exports in a single file * conditionally update Angular config * revert pathname to request * fix typo * fix merge conflicts * match version of angular/ssr instead of core * Update README.md Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com> * seperate version detection for angular/core and ssr * update tests * update failBuild message and remove dead code * update readme * allow specifying own hosts * don't inject defaults when allowedHosts includes `*` * allow trusting all proxy headers * fix set logic * fix type definition * prettify * remove unnecessary config options --------- Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
…gular-runtime#443) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* update deps, apply prettier, change to ESM, update tests * update ci tests to use Node 22 * coderabbit 1 * remove exclude * update lockfiles * lint fixes * fix prettier config * fix npm ci * coderabbit 2 * downgrade and pin angular * update engine version range to match Angular * fix version and readme * update readme to suggest latest CLI * add allowedHosts and trustedProxyHeaders * regenrate lockfiles * fix type for getContext * update readme for deploy instructions * prevent missing env vars from failing build * fix for loop bug * update swapped file templates * fix context potentially being undefined * consolidate app-engine exports in a single file * conditionally update Angular config * revert pathname to request * fix typo * fix merge conflicts * match version of angular/ssr instead of core * Update README.md Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com> * seperate version detection for angular/core and ssr * update tests * update failBuild message and remove dead code * update readme * allow specifying own hosts * don't inject defaults when allowedHosts includes `*` * allow trusting all proxy headers * fix set logic * fix type definition * prettify * remove unnecessary config options * add fixtures for Angular 22 * add SSR test * update demo to use Angular 22 * fix test * fix typescript range --------- Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
…lar-runtime#385) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lify/angular-runtime#436) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…r-runtime#444) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
…lar-runtime#431) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…gular-runtime#445) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…time#448) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…-runtime#450) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
serhalp
force-pushed
the
hk/integrate-angular-runtime
branch
from
d2d0a96 to
60cd064
Compare
auto-merge was automatically disabled
July 3, 2026 19:29
Rebase failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this guide: https://developers.netlify.com/guides/migrating-git-from-multirepo-to-monorepo-without-losing-history/, this PR just merges the codebase. The actual changes will come in a follow-up PR.
Caution
In order to actually preserve git history, it's important to use "Rebase and merge" on this PR!