Repository navigation
Fixes #45: Stabilize Redis-dependent tests when running in parallel - #46
Merged
jnovinger merged 1 commit intoOct 14, 2026
Merged
Conversation
Adds RQQueueTestMixin as the first base class in test cases that reach Redis queues, ensuring proper cleanup and preventing parallel workers from interfering. Removes manual queue cleanup and task deletion calls. Fixes #45
pheus
marked this pull request as ready for review
October 13, 2026 13:17
jnovinger
approved these changes
Oct 14, 2026
jnovinger
deleted the
45-stabilize-redis-dependent-tests-when-running-in-parallel
branch
October 14, 2026 13:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #45
Parallel test workers share the test Redis database, so cleanup in one test can interfere with another. This PR uses NetBox's
RQQueueTestMixinfor the affected test classes to serialize their execution and handle cleanup consistently.It also removes manual queue and job cleanup and updates the testing conventions to explain when the mixin is needed and why test Redis services must be isolated.