Fix dark theme select popups - #472
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughSelect controls now use explicit theme-specific color schemes. Dark-theme options use dark backgrounds, and selected options use the accent color with white text. Light-theme controls retain a light color scheme. ChangesSelect theme styling
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Native select popups now use theme-appropriate colors in dark and light modes, restoring readable dark-theme options without changing application behavior beyond select styling. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes #470
Validation
UI proof note
The pre-fix native WebView2 popup was captured on Windows. The fix is limited to the theme-specific CSS controlling that same native select. Hosted Windows CI should provide the fresh build gate; post-fix native-popup CUA is the only local check blocked by the machine linker configuration.
Summary by CodeRabbit