Skip to content

Fix Brave App-Bound Encryption cookie import messaging - #460

Merged
Finesssee merged 1 commit into
mainfrom
fix/issue-455-brave-abe
Sep 8, 2026
Merged

Fix Brave App-Bound Encryption cookie import messaging#460
Finesssee merged 1 commit into
mainfrom
fix/issue-455-brave-abe

Conversation

@Finesssee

@Finesssee Finesssee commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Report Chromium App-Bound Encryption accurately for Brave and other Chromium browsers.
  • Pass the selected browser context through cookie-import errors.
  • Correct the cookie documentation and add Brave-specific regression coverage.

Validation

  • cargo fmt --all
  • cargo test -p codexbar test_abe_error --lib
  • cargo test -p codexbar test_v20_cookie_reports_app_bound_encryption --lib
  • cargo check -p codexbar-desktop-tauri

Fixes #455

Summary by CodeRabbit

  • Bug Fixes

    • Improved cookie import error handling with clearer, browser-specific messages.
    • Error messages now accurately identify Chromium App-Bound Encryption issues across supported browsers, including Brave.
  • Documentation

    • Updated cookie import documentation to explain modern Chromium encryption, including App-Bound Encryption.
    • Clarified that some encrypted cookies cannot be imported automatically.
    • Added troubleshooting guidance for App-Bound Encryption errors and database-locking issues.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 12ce06c2-e5ec-4f0e-aae3-4c0425083052

📥 Commits

Reviewing files that changed from the base of the PR and between ca7a97b and 11dcd2b.

📒 Files selected for processing (3)
  • apps/desktop-tauri/src-tauri/src/commands/browser_import.rs
  • docs/COOKIES.md
  • rust/src/browser/cookies.rs

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The change adds browser-specific App-Bound Encryption messages for cookie extraction errors. The browser import command uses the new message method. Chromium cookie documentation now describes conditional automatic import and manual or Firefox alternatives.

Changes

Chromium ABE messaging

Layer / File(s) Summary
Browser-specific extraction errors
rust/src/browser/cookies.rs
CookieError now produces browser-specific App-Bound Encryption messages. Chromium terminology is used in errors, comments, logs, and tests.
Importer and documentation alignment
apps/desktop-tauri/.../browser_import.rs, docs/COOKIES.md
The import command uses browser-specific error messages. Documentation describes conditional Chromium import support and fallback options.

Priority: ➖ Normal — Impact reflects medium issue severity.

Estimated code review effort: 2 (Simple) | ~10 minutes

Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 11dcd

Cookie import failures caused by Chromium App-Bound Encryption now identify the selected browser, including Brave, while documentation explains the limitation and available manual or Firefox alternatives. The change is ready to merge.

Sequence Diagram(s)

sequenceDiagram
  participant BrowserImport
  participant CookieExtractor
  participant CookieError
  BrowserImport->>CookieExtractor: extract browser cookies
  CookieExtractor-->>BrowserImport: AppBoundEncryption error
  BrowserImport->>CookieError: user_message_for_browser(browser_type)
  CookieError-->>BrowserImport: browser-specific message
Loading
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: correcting Brave App-Bound Encryption cookie import messaging.
Linked Issues check ✅ Passed The changes satisfy issue #455 by providing browser-specific App-Bound Encryption messages, documenting the limitation for Chromium browsers, preserving browser and profile discovery, and adding Brave…
Out of Scope Changes check ✅ Passed The code, documentation, error-handling, and test changes directly support the linked issue objectives. No unrelated changes are identified.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 2 files. (1 skipped: 1 …
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-455-brave-abe

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Finesssee

Copy link
Copy Markdown
Collaborator Author

Thermo-nuclear code quality review: APPROVE

No structural findings.

The change keeps Chromium ABE detection in the browser layer, adds browser-specific presentation at the existing error boundary, and adds focused regression coverage. It does not add special-case branching to unrelated flows or create a new abstraction that is harder to reason about.

@Finesssee
Finesssee merged commit 0b8b3a3 into main Sep 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Brave automatic cookie import is blocked by App-Bound Encryption despite being documented as supported

1 participant