Skip to content

Use Windows typography and fix control layout - #453

Merged
Finesssee merged 6 commits into
nesszer:mainfrom
xuelongmu:fix/windows-typography-controls
Sep 8, 2026
Merged

Use Windows typography and fix control layout#453
Finesssee merged 6 commits into
nesszer:mainfrom
xuelongmu:fix/windows-typography-controls

Conversation

@xuelongmu

Copy link
Copy Markdown

Summary

Shared Windows surfaces and the floating bar now prefer Segoe UI Variable. Native selects reserve space for a bounded arrow in both themes, and Settings fields and account action rows use consistent sizing and containment.

Usage metrics, charts, pace visibility, and provider-card ordering are unchanged in this PR. The existing select interaction test is updated for the simplified control markup.

Based independently on upstream main at 029a5e3d; no other PR in this series is required.

Validation

  • Windows-native scripts/local-check.ps1 -Slice ci on 9ae96d73: workspace formatting, Clippy with -D warnings, Rust tests, frozen pnpm install, frontend tests/build, and interaction-guard script tests.
  • Rust checks used RUST_TEST_THREADS=4; no tests were filtered out (the existing opt-in compatibility test remains ignored where present).
  • Local PATH runtime: Node 22.23.2; bundled pnpm 11.19.0 (launcher uses Node 24.19.0). Hosted CI retains the repository-pinned Node/pnpm versions.
  • Fresh pnpm --dir apps/desktop-tauri run tauri:build:debug for this exact branch.
  • Scoped extraction review and git diff --check.
  • Full installer/release validation is outside this change; no installer or release configuration changed.

UI / tray proof

CUA Driver checks were performed against the freshly rebuilt executable for this branch. Verified General settings in Auto/dark and Light: readable Windows typography and bounded select arrows. Restored Auto, enabled the floating bar, confirmed its native window and rendered provider pills while Settings stayed dark, then restored the floating bar to off. Scrolled Codex account controls and verified complete Refresh usage, Switch, Remove, and Add account labels within the panel.

Local proof: .local/upstream-split/proof5/general-current.png, .local/upstream-split/proof5/general-key.png, .local/upstream-split/proof5/menu-float-enabled.png, .local/upstream-split/proof5/float.png, .local/upstream-split/proof5/account-actions.png. Account screenshots remain local because they contain private identities; this note records the observed behavior.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 753d7308-72a5-4dbd-9991-911b3679cd87

📥 Commits

Reviewing files that changed from the base of the PR and between 34c7429 and 836417d.

📒 Files selected for processing (6)
  • apps/desktop-tauri/src/components/FormControls.tsx
  • apps/desktop-tauri/src/floatbar/FloatBar.css
  • apps/desktop-tauri/src/main.tsx
  • apps/desktop-tauri/src/styles.css
  • apps/desktop-tauri/src/surfaces/settings/settings-layout.css
  • apps/desktop-tauri/src/surfaces/settings/tabs/GeneralTab.test.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Finesssee

Copy link
Copy Markdown
Collaborator

Thermo-nuclear code quality review: CHANGES

P2: this adds another feature-specific block to a 6k-line global stylesheet

apps/desktop-tauri/src/styles.css grows from 6,015 to 6,072 lines. The new block starting around line 6014 mixes global typography with Settings section layout and Codex-account-specific credential-card rules. The .select SVG/background declarations are also repeated for the light-theme selector even though the values are identical.

Keep the font token/global control primitive here, but move Settings/account layout into a focused Settings stylesheet or owning component styles, and collapse the duplicate select declarations. The current direction makes an already giant shared file harder to reason about for unrelated UI work.

@Finesssee
Finesssee merged commit 8239f24 into nesszer:main Sep 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants