do not raise exception when an optional source file is missing#27
Open
flavray wants to merge 1 commit intonerdEd:masterfrom
Open
do not raise exception when an optional source file is missing#27flavray wants to merge 1 commit intonerdEd:masterfrom
flavray wants to merge 1 commit intonerdEd:masterfrom
Conversation
stephenyeargin
requested changes
Feb 20, 2021
Collaborator
stephenyeargin
left a comment
There was a problem hiding this comment.
Took a swing at cleaning up the merge conflicts but ran into issues with the test case. If you have a second to merge master back into your branch I think we can get this one done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #12 - missing optional files normally do not raise GTFS::InvalidSourceException anymore
If an optional file is missing,
parse_entityyields a new empty instance of StringIO, when callingreadon this StringIO, an empty string will be returned causingparse_modelsto return an empty array.If a required file is missing, raise GTFS::InvalidSourceException as before.
I added a test on
transfersfield,transfers.txtis missing invalid_gtfs_missing_optional_files.zipbut callingsource.transfersdoes not raise an exception anymore :)