Either short_name or long_name required#25
Open
geofflane wants to merge 1 commit intonerdEd:masterfrom
Open
Conversation
Both are not required in the spec and without this change Routes without both are excluded from the results.
stephenyeargin
requested changes
Feb 20, 2021
Collaborator
stephenyeargin
left a comment
stephenyeargin
left a comment
There was a problem hiding this comment.
LGTM once the merge conflict clears.
| has_required_attrs :id, :short_name, :long_name, :type | ||
| has_optional_attrs :agency_id, :desc, :url, :color, :text_color | ||
| has_required_attrs :id, :type | ||
| has_optional_attrs :agency_id, :desc, :url, :color, :text_color, :short_name, :long_name |
Collaborator
There was a problem hiding this comment.
This should clear the merge conflict.
Suggested change
| has_optional_attrs :agency_id, :desc, :url, :color, :text_color, :short_name, :long_name | |
| has_optional_attrs :agency_id, :desc, :url, :color, :text_color, :sort_order, :short_name, :long_name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both are not required in the spec and without this change Routes without
both are excluded from the results.
This should fix Issue #24