This repository was archived by the owner on May 18, 2019. It is now read-only.
Dev/deploy to maven repo#17
Open
peterszatmary wants to merge 2 commits intoneo-project:masterfrom
peterszatmary:dev/deploy-to-maven-repo
Open
Dev/deploy to maven repo#17peterszatmary wants to merge 2 commits intoneo-project:masterfrom peterszatmary:dev/deploy-to-maven-repo
peterszatmary wants to merge 2 commits intoneo-project:masterfrom
peterszatmary:dev/deploy-to-maven-repo
Conversation
Member
|
I am not familiar with Java, who can review it? |
Contributor
Author
|
Aditional informations below. pom.xml file was changed because there are validation steps in maven repository that have to each new artifact pass. Here are all pom.xml changes that i made described pom.xml valid for deploying artifact Validations that neo-devpack-java passed succesfully
Functionality check is possible as described in README by creating smart contract with mentioned pom.xml file and see if maven or gradle etc is able to download automatically neo-devpack-java dependency for you. This new pull request was created to fix wrong dependency call in ICO template example in java-examples. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This configuration was used for successful deployment of neo-devpack-java artifakt to maven repository.