Skip to content

Fix TextInput placeholder documentation - #2854

Open
huytdps13400 wants to merge 1 commit into
necolas:masterfrom
huytdps13400:fix/2693-text-input-placeholder-doc-type
Open

huytdps13400 wants to merge 1 commit into
necolas:masterfrom
huytdps13400:fix/2693-text-input-placeholder-doc-type

Conversation

@huytdps13400

Copy link
Copy Markdown

Summary

  • correct the documented TextInput placeholder prop type from boolean to string
  • align the generated documentation with the existing public Flow type

Fixes #2693.

Verification

  • npm run build -w react-native-web-docs: passed; generated TextInput page renders placeholder as ?string
  • npm run test: Flow, Prettier, ESLint, 46 DOM suites / 712 tests passed, 3 Node suites / 6 tests passed
  • git diff --check: passed

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 21064e3:

Sandbox Source
react-native-web-examples Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type error in docs for TextInput

1 participant