Repository navigation
Conversation
Co-Authored-By: Claude Code <noreply@anthropic.com>
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f809cf7e4f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Code <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ea00b902f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| UI.openRefactoringUI( | ||
| new KotlinRenameRefactoringUI(psi, new RenameRefactoring(Lookups.fixed(psi, doc, caretPosition))), | ||
| TopComponent.getRegistry().getActivated()); | ||
| if (ec != null && ec.getOpenedPanes() != null && ec.getOpenedPanes().length > 0) { |
There was a problem hiding this comment.
When a Kotlin file is already open and Rename is invoked from its Projects/Files node, that DataNode lookup exposes an EditorCookie with nonempty opened panes, so this branch consumes the node request and launches symbol rename at the editor caret instead of reaching selectedKotlinFile() for physical rename. Fresh evidence after the earlier branch-order fix is that an open project node carries both node and editor cookies, so opened-pane state still cannot identify the invocation source; check the selected-node/Explorer context before choosing the editor route.
Useful? React with 👍 / 👎.
| * @return selected valid Kotlin file, or {@code null} for folders and unrelated selections | ||
| */ | ||
| private FileObject selectedKotlinFile(Lookup lookup) { | ||
| FileObject file = lookup.lookup(FileObject.class); |
There was a problem hiding this comment.
When at least two unopened Kotlin file nodes are selected, NetBeans' merged node lookup makes lookup(FileObject.class) return one match rather than reporting ambiguity. canRename() consequently returns true and doRename() opens physical rename for an arbitrary file, whereas the surrounding node actions require exactly one node; validate lookupAll(Node.class) or equivalent file cardinality before returning a target.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
python3 build-scripts/update-copyright.py --checkmvn clean testmvn clean package -DskipTests(NBM built successfully)Nbm/target/nbm/netbeans-plugin-kotlin-nbm-0.11.288-SNAPSHOT.nbm🤖 Generated with Claude Code