Repository navigation
Fixed "OpenAI-compatible API" connection type being reset to "Claude-compatible API" on the Default profile - #194
Conversation
…compatible API" on the Default profile (nbplugins#191) Resolves: nbplugins#191 The Default profile was rebuilt from stored settings by copying fields one by one, and the openaiProxy flag was not copied, so the connection type was re-derived as OTHER_API. The connection type is now stored explicitly as connectionType; the Default profile is deserialised as a whole like named profiles. Settings written by older versions (legacy openaiProxy / openaiSubscription flags, no connectionType) are still read and the type is derived from them; settings are always written in the new format. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17386a36eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Copy Profile copied only token, apiKey and baseUrl, so with the connection type now stored explicitly a copy of a profile whose type is not inferable from its credentials (e.g. Other API before a key is entered, or OpenAI profiles) opened as Claude-managed. Extracted ClaudeProfilesPanel.copyOf() and made it copy the connection type. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a205c18ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…on profile copyOf() preserved the connection type but not the chatgpt* OAuth fields, so a copy of a signed-in ChatGPT Subscription profile was reported as not signed in and could not start a session. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Resolves #191
Summary
openaiProxywas not copied, so the type was re-derived as "Claude-compatible API". Named profiles were unaffected.connectionTypeenum); the Default profile is deserialised as a whole, so no field can be forgotten.openaiProxy/openaiSubscriptionflags, noconnectionType) are still read; settings are always written in the new format.Test plan
expected OPENAI_PROXY but was OTHER_API)ClaudeProfileStoreConnectionTypeTest: Default/Custom × old/new settings × all connection types, edge cases, lossless writemvn package— 1125 tests, 0 failures🤖 Generated with Claude Code