fix: handle boolean true in nativeStyleMapping#323
Open
danstepanov wants to merge 1 commit intomainfrom
Open
Conversation
When nativeStyleMapping uses `true` (e.g. `textAlign: true`), the value
should be treated as the key name itself. Previously, `true.split(".")`
would throw a TypeError at runtime, breaking TextInput and
ImageBackground components that use this pattern.
Converts boolean `true` values to the key name during config creation
in useNativeCss so the runtime always receives strings.
Fixes #232
Contributor
|
Thanks for picking this up! One small thing that might be worth an extra test: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nativeStyleMappingallowstrueas a value (e.g.textAlign: trueon TextInput,backgroundColor: trueon ImageBackground), meaning "extract this property from style and set it as a prop with the same name"path.split(".")which throwsTypeErroron booleantruetrueto the key name during config creation inuseNativeCss, so the runtime always receives stringsTest plan
styled()componentsFixes #232
Supersedes #251