fix: resolve @angular/common/locales bare specifier#85
Open
Aukevanoost wants to merge 1 commit into
Open
Conversation
Aukevanoost
force-pushed
the
issues/port-1107
branch
from
4d9417b to
060dda9
Compare
Aukevanoost
force-pushed
the
issues/port-1107
branch
from
060dda9 to
712b6a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port from angular-architects/module-federation-plugin#1107
This pull request improves support for Angular i18n locale data in the build system by ensuring that non-English locale data files are properly registered in the federation config. The main changes include introducing new utility functions to resolve and register Angular locale data, updating the build process to call these utilities, and adding comprehensive tests to verify the new behavior.
Enhancements for Angular i18n locale data handling:
src/builders/build/i18n.ts: Added theresolveAngularLocaleDataandregisterAngularLocaleDataInFederationConfigfunctions to locate and register Angular locale data files as shared entries in the federation config, mirroring Angular’s own fallback logic for locale tags.src/builders/build/builder.ts: Updated the build process to callregisterAngularLocaleDataInFederationConfigbefore external dependencies are resolved, ensuring that required locale data is surfaced and marked as external. [1] [2]Testing improvements:
src/builders/build/i18n-locale-data.spec.ts: Added a comprehensive test suite for the new locale data resolution and registration logic, covering various scenarios including fallback behavior, user overrides, and error handling.Type and import updates:
src/builders/build/i18n.ts: Updated type imports to include new types used by the locale data registration logic.