Skip to content

Conversation

@SajjadPourali
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces granular TCP configuration through a new TcpConfig struct, replacing the single tcp_timeout field in IpStackConfig with configurable timeout values for different TCP states and operations. This change provides more fine-grained control over TCP behavior without breaking the existing API significantly.

  • Replaces single tcp_timeout field with comprehensive TcpConfig struct containing multiple timeout parameters
  • Updates all TCP timeout-related code to use configurable values instead of hardcoded constants
  • Modifies the example to demonstrate the new configuration approach

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/stream/tcp.rs Introduces TcpConfig struct and updates TCP stream implementation to use configurable timeouts
src/stream/mod.rs Exports the new TcpConfig struct
src/lib.rs Updates IpStackConfig to use TcpConfig and replaces tcp_timeout method with with_tcp_config
examples/tun.rs Updates example to use the new TCP configuration API

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SajjadPourali
Copy link
Collaborator Author

#64

@ssrlive
Copy link
Collaborator

ssrlive commented Oct 7, 2025

Good work.

@SajjadPourali SajjadPourali requested a review from Copilot October 9, 2025 01:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SajjadPourali SajjadPourali requested a review from Copilot October 9, 2025 01:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SajjadPourali SajjadPourali merged commit e240ff1 into main Oct 9, 2025
4 checks passed
@SajjadPourali SajjadPourali deleted the TcpConfig branch October 9, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants