Skip to content

Conversation

@ssrlive
Copy link
Collaborator

@ssrlive ssrlive commented Feb 15, 2025

No description provided.

@SajjadPourali
Copy link
Collaborator

@ssrlive Thanks! Let’s not expose IpNumber if you agree, as discussed #52

@ssrlive
Copy link
Collaborator Author

ssrlive commented Feb 16, 2025

I have also explained that if the customors uses IpNumber and explicitly specifies ipstack::IpNumber instead of etherparse::IpNumber, there will be no problems.
What do you think about this?

@ssrlive
Copy link
Collaborator Author

ssrlive commented Feb 16, 2025

I hope that by exporting IpNumber here, the ipstack users will not have to introduce a dependency on etherparse.

@ssrlive
Copy link
Collaborator Author

ssrlive commented Feb 16, 2025

To be on the safe side, please publish the crate in a major version, such as 0.2.0.

@SajjadPourali SajjadPourali merged commit 4868f25 into narrowlink:main Feb 16, 2025
2 checks passed
@SajjadPourali
Copy link
Collaborator

@ssrlive Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants