fix: record and lock Rust release dependencies - #1206
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release source commits previously omitted
Cargo.lock, and CI could resolve newer Rust dependencies when rebuilding the same commit. Track the workspace lockfile and build with--lockedso future release commits record the resolved crate versions and dependency drift fails the build.--lockedto every native build path, including benchmarks, WASI, FreeBSD, and Clippy.--locked, leaving Argon2 unprotected even when the workflow supplied it.matrix.settings.setupfield, allowing workflow validation to pass.This follows canvas #1336. It records dependencies for future releases; it does not reconstruct dependency sets for older binaries.
Validation:
--lockedand the lockfile stayed unchanged.actionlint.renovate-config-validator --strict renovate.json.Fixes #1200.