Skip to content

fix: remove forced SSE4.2 from x64 builds - #1205

Merged
Brooooooklyn merged 1 commit into
mainfrom
codex/fix-crc32-x64-cpu-baseline
Sep 10, 2026
Merged

fix: remove forced SSE4.2 from x64 builds#1205
Brooooooklyn merged 1 commit into
mainfrom
codex/fix-crc32-x64-cpu-baseline

Conversation

@Brooooooklyn

Copy link
Copy Markdown
Member

Published CRC32 addons crash during module registration on older x64 CPUs without SSSE3. The global +sse4.2 compiler flag permits unsupported instructions throughout the addon and makes SSE4.2 feature checks unconditionally true.

Remove the forced feature from Linux GNU and Windows MSVC x64 builds. crc32fast and crc32c already select accelerated implementations at runtime, so newer CPUs retain hardware acceleration while older CPUs can use the software paths.

Fixes #1016.

Validation:

  • Reproduced SIGILL in published GNU x64 versions 1.10.6 and 1.10.7 under QEMU's Opteron G3 model; GDB confirmed pshufb as the faulting instruction in 1.10.6.
  • Rebuilt the GNU x64 addon with Rust 1.98.1 and tested it using Node 18.20.8 under Opteron G3, qemu64 with SSSE3/SSE4.1/SSE4.2/PCLMUL disabled, and max.
  • All three CPU models pass module loading, standard CRC vectors, 324 buffer cases covering lengths, alignment and initial states, incremental checksums, and UTF-8 string inputs.
  • Confirmed the rebuilt binary still contains accelerated CRC32 and PCLMUL instructions. Formatting and whitespace checks pass.

Runtime validation used Linux CPU emulation. Native Windows execution and physical older-CPU testing were not performed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T03:13:13.597267Z 2490362 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Brooooooklyn
Brooooooklyn merged commit b8b4fae into main Sep 10, 2026
36 checks passed
@Brooooooklyn
Brooooooklyn deleted the codex/fix-crc32-x64-cpu-baseline branch September 10, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Published @node-rs/crc32-linux-x64-gnu requires SSSE3

1 participant