Restrict docker to build step#777
Open
ada-x64 wants to merge 1 commit into
Open
Conversation
Fixes #666. Only ./z build (and ./z build --with-docker) may spawn docker; setup/test/release/lint/benchmark now do so by construction. - build.install(): drop dead Windows/docker branch. Windows installs ride inside docker_build's install_destdir path. - _docker: remove now-unused docker_install and clean_volume. - z._make_args: opt-in with_docker flag; only build() sets it. - Makefile.nanvix: install target native-only.
There was a problem hiding this comment.
Pull request overview
This PR tightens the Nanvix CPython build orchestration so that Docker execution is gated to the ./z build flow, aligning with issue #666’s requirement that non-build steps run natively on the host.
Changes:
- Make
Makefile.nanvix’sinstalltarget native-only (no$(DOCKER_RUN)path). - Add an explicit
with_dockeropt-in to.nanvix/z.py::_make_args()and enable it only frombuild(). - Remove now-unused Docker helpers (
docker_install,clean_volume) and simplify the staging install helper to drop the Windows/Docker branch.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Makefile.nanvix | Removes Docker wrapping from the install target to prevent non-build Docker invocation. |
| .nanvix/z.py | Adds a with_docker gate so only build() can request Docker-enabled make args. |
| .nanvix/build.py | Removes the Windows/Docker-specific install path and clarifies install staging behavior. |
| .nanvix/_docker.py | Deletes unused Docker entry points now that non-build flows should not invoke Docker. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #666. Only ./z build (and ./z build --with-docker) may spawn
docker. Currently, setup/test/release/lint/benchmark do so by construction.