Skip to content

Add Source Link and reproducible package metadata - #290

Merged
josesimoes merged 2 commits into
nanoframework:developfrom
josesimoes:josesimoes-source-link-system-text
Oct 14, 2026
Merged

josesimoes merged 2 commits into
nanoframework:developfrom
josesimoes:josesimoes-source-link-system-text

Conversation

@josesimoes

@josesimoes josesimoes commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Description

  • Add Source Link build dependencies and guarded imports.
  • Enable deterministic builds with embedded sources, portable symbols and symbol packages.
  • Lock the new development dependencies for reproducible restore.

Motivation and Context

Allows debugging the NuGet packages with source stepping and makes builds reproducible.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

@nfbot nfbot left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ The PR template looks good now. Thanks!

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: nanoframework/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 81a4649e-4133-4707-93c5-afde7ae411eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@sonarqubecloud

Copy link
Copy Markdown

@josesimoes
josesimoes marked this pull request as ready for review October 14, 2026 12:01
@josesimoes

Copy link
Copy Markdown
Member Author

Ignoring nuget version check.

@josesimoes
josesimoes merged commit 0fe4070 into nanoframework:develop Oct 14, 2026
4 of 7 checks passed
@josesimoes
josesimoes deleted the josesimoes-source-link-system-text branch October 14, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants