-
Notifications
You must be signed in to change notification settings - Fork 52.6k
feat: Allow to set ChatHub workflow agent icon in NDV #23562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BundleMonFiles added (2)
Total files change +255.73KB Groups added (2)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
E2E Tests: n8n tests passed after 4m 17.7s Run Details
This message was posted automatically by
currents.dev | Integration Settings
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 10 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/frontend/editor-ui/src/features/ndv/parameters/components/ParameterInput.vue">
<violation number="1" location="packages/frontend/editor-ui/src/features/ndv/parameters/components/ParameterInput.vue:1354">
P2: Missing read-only handling for `N8nIconPicker`. All other input components in this file disable interaction when `isReadOnly` is true, but this picker remains interactive. Consider either adding disabled prop support to N8nIconPicker or conditionally rendering a non-interactive display when `isReadOnly` is true.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
packages/frontend/editor-ui/src/features/ndv/parameters/components/ParameterInput.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks like I expected, nice to get rid of the project icons.
maybe worth getting the check from nodes team too.
Summary
This PR makes it possible for ChatHub workflow agent creator to set an emoji or icon for their agent, making it easier for chat users to recognize the agent. The icon appears in ChatHub model selector as well as conversation history.
To support this feature, new node parameter type
iconis introduced.Screen.Recording.2025-12-23.at.11.47.52.mov
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CHA-85/feature-chat-hub-icon-parameter-in-chat-trigger-node
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)