fix(core): Stronger allowed path enforcement for read/write Node #23542
+323
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/core/src/execution-engine/node-execution-context/utils/file-system-helper-functions.ts">
<violation number="1" location="packages/core/src/execution-engine/node-execution-context/utils/file-system-helper-functions.ts:133">
P1: File handle resource leak: If `fileHandle.stat()` throws or the identity check fails, the opened file handle is never closed. Unlike `writeContentToFile` which uses try/finally, this function lacks cleanup for the error path. Add `await fileHandle.close()` before throwing or wrap in try/catch.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| // Verify that the handle we've opened is the same as the path we checked earlier. | ||
| // This ensures nothing has changed between checking and reading. | ||
| const fileHandleIdentity = await fileHandle.stat(); | ||
| if ( |
Contributor
There was a problem hiding this comment.
P1: File handle resource leak: If fileHandle.stat() throws or the identity check fails, the opened file handle is never closed. Unlike writeContentToFile which uses try/finally, this function lacks cleanup for the error path. Add await fileHandle.close() before throwing or wrap in try/catch.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/core/src/execution-engine/node-execution-context/utils/file-system-helper-functions.ts, line 133:
<comment>File handle resource leak: If `fileHandle.stat()` throws or the identity check fails, the opened file handle is never closed. Unlike `writeContentToFile` which uses try/finally, this function lacks cleanup for the error path. Add `await fileHandle.close()` before throwing or wrap in try/catch.</comment>
<file context>
@@ -108,34 +112,59 @@ export const getFileSystemHelperFunctions = (node: INode): FileSystemHelperFunct
+ // Verify that the handle we've opened is the same as the path we checked earlier.
+ // This ensures nothing has changed between checking and reading.
+ const fileHandleIdentity = await fileHandle.stat();
+ if (
+ fileHandleIdentity.dev !== pathIdentity.dev ||
+ fileHandleIdentity.ino !== pathIdentity.ino
</file context>
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
Found 5 test failures on Blacksmith runners: Failures
|
|
Found 3 test failures on Blacksmith runners: Failures
|
|
E2E Tests: n8n tests failed after 9m 32.9s Run Details
Failed Spec Files
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)